Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

complete transition to types-index #10175

Merged
merged 6 commits into from
Oct 1, 2024
Merged

Conversation

turadg
Copy link
Member

@turadg turadg commented Sep 30, 2024

refs: #10086

Description

Brings all remaining packages into compliance with the best practice documented in #10158

Also has some other cleanup, separated by commit

Security Considerations

n/a

Scaling Considerations

n/a

Documentation Considerations

none

Testing Considerations

none

Upgrade Considerations

none

@turadg turadg requested a review from a team as a code owner September 30, 2024 18:58
Copy link

cloudflare-workers-and-pages bot commented Sep 30, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7a50ef8
Status: ✅  Deploy successful!
Preview URL: https://5d55f278.agoric-sdk.pages.dev
Branch Preview URL: https://10086-complete-types-index.agoric-sdk.pages.dev

View logs

Copy link
Member

@0xpatrickdev 0xpatrickdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The CI failure seems unrelated to these changes

@turadg turadg added the automerge:rebase Automatically rebase updates, then merge label Oct 1, 2024
@turadg turadg force-pushed the 10086-complete-types-index branch from 6b3bbd9 to 7a50ef8 Compare October 1, 2024 16:00
@turadg turadg changed the title 10086 complete types-index complete transition to types-index Oct 1, 2024
@mergify mergify bot merged commit c9ce088 into master Oct 1, 2024
82 of 83 checks passed
@mergify mergify bot deleted the 10086-complete-types-index branch October 1, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants